[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 10/10] qemu-iotests/118: Test media
|
From: |
Sascha Silbe |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 10/10] qemu-iotests/118: Test media change with qdev name |
|
Date: |
Thu, 15 Sep 2016 18:28:38 +0200 |
|
User-agent: |
Notmuch/0.22.1~rc0 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) |
Dear Eric,
Sascha Silbe <address@hidden> writes:
> result = self.vm.qmp('blockdev-change-medium',
> id=self.device_name or 'drive0',
> filename=new_img,
> format=iotests.imgfmt)
Sorry, my eyes deceived me. I thought the original code was setting the
"id" parameter in both cases. QEMUMachine.qmp() and
QEMUMonitorProtocol.cmd() together translate the keyword arguments
directly into QMP arguments, so passing None is different from not
passing anything at all. The if/else is probably the best approach in
that case; everything else I can think of would just be more
complicated.
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641