[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 04/10] block: Accept device model name for bl
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v3 04/10] block: Accept device model name for blockdev-open/close-tray |
|
Date: |
Tue, 20 Sep 2016 12:55:20 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/20/2016 06:38 AM, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
What you have works, but still feels a bit awkward to this native
speaker. You could get away with the shorter:
In order to remove the need for BlockBackend names...
Up to you if you want to tweak the series (many commits share this pattern).
> external API, we want to allow qdev device names in all device related
> commands.
>
> This converts blockdev-open/close-tray to accept a qdev device name.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> blockdev.c | 61
> ++++++++++++++++++++++++++++++++++++++-------------
> docs/qmp-commands.txt | 12 ++++++----
> qapi/block-core.json | 14 ++++++++----
> 3 files changed, 64 insertions(+), 23 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 00/10] block: Accept qdev IDs in device level QMP commands, Kevin Wolf, 2016/09/20
- [Qemu-block] [PATCH v3 02/10] qdev-monitor: Factor out find_device_state(), Kevin Wolf, 2016/09/20
- [Qemu-block] [PATCH v3 01/10] block: Add blk_by_dev(), Kevin Wolf, 2016/09/20
- [Qemu-block] [PATCH v3 03/10] qdev-monitor: Add blk_by_qdev_id(), Kevin Wolf, 2016/09/20
- [Qemu-block] [PATCH v3 04/10] block: Accept device model name for blockdev-open/close-tray, Kevin Wolf, 2016/09/20
- Re: [Qemu-block] [PATCH v3 04/10] block: Accept device model name for blockdev-open/close-tray,
Eric Blake <=
- [Qemu-block] [PATCH v3 05/10] block: Accept device model name for x-blockdev-insert-medium, Kevin Wolf, 2016/09/20
- [Qemu-block] [PATCH v3 06/10] block: Accept device model name for x-blockdev-remove-medium, Kevin Wolf, 2016/09/20
- [Qemu-block] [PATCH v3 07/10] block: Accept device model name for eject, Kevin Wolf, 2016/09/20
- [Qemu-block] [PATCH v3 08/10] block: Accept device model name for blockdev-change-medium, Kevin Wolf, 2016/09/20
- [Qemu-block] [PATCH v3 09/10] block: Accept device model name for block_set_io_throttle, Kevin Wolf, 2016/09/20
- [Qemu-block] [PATCH v3 10/10] qemu-iotests/118: Test media change with qdev name, Kevin Wolf, 2016/09/20
- Re: [Qemu-block] [PATCH v3 00/10] block: Accept qdev IDs in device level QMP commands, Eric Blake, 2016/09/20