Re: [Qemu-block] [PATCH v2 09/11] qemu-iotests/139: Avoid blockdev-add with id

[Eric Blake]

On 09/20/2016 08:03 AM, Kevin Wolf wrote:
> We want to remove the 'id' option for blockdev-add. This removes one
> user of the option and makes it use only node names.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/qemu-iotests/139     | 178 
> +++++++++++++++------------------------------
>  tests/qemu-iotests/139.out |   4 +-
>  2 files changed, 59 insertions(+), 123 deletions(-)
> 

> @@ -1,5 +1,5 @@
> -............
> +.........
>  ----------------------------------------------------------------------
> -Ran 12 tests
> +Ran 9 tests

Might be worth expanding the commit message to mention that deleted test
cases are intentional (similar to the longer message in 2/11).

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature