[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 10/12] block: Avoid printing NULL string in e
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 10/12] block: Avoid printing NULL string in error messages |
Date: |
Wed, 21 Sep 2016 09:16:08 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/21/2016 07:56 AM, Kevin Wolf wrote:
> Even for nodes that have a BlockBackend attached, bdrv_get_parent_name()
> can return NULL if the BB is anonymous (e.g. it belongs to a block job
> or a device that was created with a drive=<node-name> option).
>
> Remove the information from the error message. The user probably knows
> already why the node is still in use.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> blockdev.c | 9 +++------
> tests/qemu-iotests/085.out | 6 +++---
> 2 files changed, 6 insertions(+), 9 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 02/12] qemu-iotests/067: Avoid blockdev-add with id, (continued)
- [Qemu-block] [PATCH v3 02/12] qemu-iotests/067: Avoid blockdev-add with id, Kevin Wolf, 2016/09/21
- [Qemu-block] [PATCH v3 01/12] qemu-iotests/041: Avoid blockdev-add with id, Kevin Wolf, 2016/09/21
- [Qemu-block] [PATCH v3 05/12] qemu-iotests/087: Avoid blockdev-add with id, Kevin Wolf, 2016/09/21
- [Qemu-block] [PATCH v3 06/12] qemu-iotests/117: Avoid blockdev-add with id, Kevin Wolf, 2016/09/21
- [Qemu-block] [PATCH v3 07/12] qemu-iotests/118: Avoid blockdev-add with id, Kevin Wolf, 2016/09/21
- [Qemu-block] [PATCH v3 08/12] qemu-iotests/124: Avoid blockdev-add with id, Kevin Wolf, 2016/09/21
- [Qemu-block] [PATCH v3 11/12] qemu-iotests/141: Avoid blockdev-add with id, Kevin Wolf, 2016/09/21
- [Qemu-block] [PATCH v3 09/12] qemu-iotests/139: Avoid blockdev-add with id, Kevin Wolf, 2016/09/21
- [Qemu-block] [PATCH v3 10/12] block: Avoid printing NULL string in error messages, Kevin Wolf, 2016/09/21
- Re: [Qemu-block] [PATCH v3 10/12] block: Avoid printing NULL string in error messages,
Eric Blake <=
- [Qemu-block] [PATCH v3 12/12] block: Remove BB interface from blockdev-add/del, Kevin Wolf, 2016/09/21
- Re: [Qemu-block] [PATCH v3 00/12] block: Remove BB interface from blockdev-add/del, Kevin Wolf, 2016/09/21