Re: [Qemu-block] [Qemu-devel] [PULL 00/33] Block layer patches

[Peter Maydell]

On 22 September 2016 at 17:29, Kevin Wolf <address@hidden> wrote:
> The following changes since commit 430da7a81d356e368ccd88dcca60f38da9aa5b9a:
>
>   Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20160915' 
> into staging (2016-09-22 15:39:54 +0100)
>
> are available in the git repository at:
>
>
>   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 5dccdc1b1e0c57746e5f90c69f697029a3686b5f:
>
>   block: Remove BB interface from blockdev-add/del (2016-09-22 18:02:15 +0200)
>
> ----------------------------------------------------------------
> Block layer patches
>
> ----------------------------------------------------------------

Hi; I'm afraid this fails to build on OSX: it looks like you
changed the arguments to some qmp functions but forgot to change
their callsites in ui/cocoa.m.

/Users/pm215/src/qemu-for-merges/ui/cocoa.m:1088:86: error: too few
arguments to function call, expected 7, have 4
    qmp_eject([drive cStringUsingEncoding: NSASCIIStringEncoding],
false, false, &err);
    ~~~~~~~~~
              ^
./qmp-commands.h:109:1: note: 'qmp_eject' declared here
void qmp_eject(bool has_device, const char *device, bool has_id, const
char *id, bool has_force, bool force, Error **errp);
^
/Users/pm215/src/qemu-for-merges/ui/cocoa.m:1127:40: error: too few
arguments to function call, expected 10, have 7
                                   &err);
                                       ^
./qmp-commands.h:61:1: note: 'qmp_blockdev_change_medium' declared here
void qmp_blockdev_change_medium(bool has_device, const char *device,
bool has_id, const char *id, const char *filename, bool has_format,
const char *fo...
^

thanks
-- PMM