[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2] block: Turn on "unmap" in activ
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2] block: Turn on "unmap" in active commit |
|
Date: |
Tue, 27 Sep 2016 18:13:38 +0800 |
|
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Tue, 09/27 17:33, Fam Zheng wrote:
> We already specified BDRV_O_UNMAP when opening images in 'qemu-img
> commit', but didn't turn on the "unmap" in the active commit job. This
> patch fixes that so that zeroed clusters in top image can be discarded
> which is desired in the virt-sparsify use case, where a temporary
> overlay is created and fstrim'ed before commiting back, to free space in
> the original image.
>
> This also enables it for block-commit.
>
> Signed-off-by: Fam Zheng <address@hidden>
Sent too soon. I see a number of iotests failures (020 040 097 129),
still investigating.
Fam