Re: [Qemu-block] [Qemu-devel] block/ssh:Allow blockdev-add for ssh

[Ashijeet Acharya]

On Thu, Sep 29, 2016 at 8:32 PM, Kevin Wolf <address@hidden> wrote:
> Am 29.09.2016 um 16:07 hat Ashijeet Acharya geschrieben:
>> Other than that I also asked if I have accidentally missed any other
>> important field regarding the structure 'BlockdevOptionsSsh' I
>> described in the previous mail (I will post it here again for
>> convenience)
>>
>> { 'struct': 'BlockdevOptionsSsh',
>>   'data': { 'tcp': 'InetSocketAddress',
>>              'path': 'str' } }
>>
>> It will be better if I know it beforehand and build up the patch based
>> on the suggestions.
>
> Sorry, I missed this part. Yes, there are a few more options. Just check
> ssh_runtime_opts. You wil replace the existing 'host'/'port' by 'tcp' (I
> think I would call the option something like 'server' instead of 'tcp',
> though). 'path' is already here. This leaves 'user' and 'host_key_check'
> that are missing.

Sure, I will rename it to 'server'.
Thanks for the help. I will post the patch for review soon.

Ashijeet
> Kevin