[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block: Add bdrv_runtime_opts to query-command-l
|
From: |
Michal Privoznik |
|
Subject: |
Re: [Qemu-block] [PATCH] block: Add bdrv_runtime_opts to query-command-line-options |
|
Date: |
Thu, 6 Oct 2016 12:01:20 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 06.10.2016 11:40, Kevin Wolf wrote:
> Recently we moved a few options from QemuOptsLists in blockdev.c to
> bdrv_runtime_opts in block.c in order to make them accissble using
> blockdev-add. However, this has the side effect that these options are
> missing from query-command-line-options now, and libvirt consequently
> disables the corresponding feature.
>
> This problem was reported as a regression for the 'discard' option,
> introduced in commit 818584a4. However, it is more general than that.
>
> Fix it by adding bdrv_runtime_opts to the list of QemuOptsLists that are
> returned in query-command-line-options. For the future, libvirt is
> advised to use QMP schema introspection for block device options.
>
> Reported-by: Michal Privoznik <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
Tested-by: Michal Privoznik <address@hidden>
Thank you for such a prompt fix!
Michal