qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 1/1] block: add gluster ifdef guard checks fo


From: Eric Blake
Subject: Re: [Qemu-block] [PATCH v2 1/1] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support
Date: Fri, 7 Oct 2016 17:21:24 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 10/07/2016 04:48 PM, Jeff Cody wrote:
> Add checks to see if the system compiling QEMU has support for
> SEEK_HOLE/SEEK_DATA.  If the system does not, we will flag that seek
> data is unsupported in gluster.
> 
> Note: this is not a check on whether the gluster server itself supports
> SEEK_DATA (that is already done during runtime), but rather if the
> compilation environment supports SEEK_DATA.
> 
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> 
> Changes from v1:
>     - Fixed undefined variable warnings by moving variable declarations
>     - Add a bit more whitespace to improve readability
> 
> 
>  block/gluster.c | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)

Tested-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]