[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2] build: Work around SIZE_MAX bug in OSX heade
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v2] build: Work around SIZE_MAX bug in OSX headers |
|
Date: |
Mon, 10 Oct 2016 13:38:40 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/10/2016 10:12 AM, Peter Maydell wrote:
>> v2: rewrite into a configure check (not sure if directly adding a
>> -D to QEMU_CFLAGS is the best, so advice welcome)
>
> Writing into config-host.mak would be preferable I think.
>
Okay, attempted in v4.
>> I lack easy access to a Mac box, so this is untested as to whether
>> it actually solves the issue...
>
> I ran a test with one of the cast workarounds locally removed,
> and this patch does allow the %zu version to build OK on OSX.
Thanks. But v3 leaves off Tested-by, because I still need to make sure
my configure magic worked correctly :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature