[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 07/18] block: introduce bdrv_poll_while and bdrv
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH 07/18] block: introduce bdrv_poll_while and bdrv_wakeup |
Date: |
Mon, 17 Oct 2016 09:54:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 16/10/2016 12:25, Stefan Hajnoczi wrote:
> On Thu, Oct 13, 2016 at 07:34:11PM +0200, Paolo Bonzini wrote:
>> @@ -485,9 +474,14 @@ void bdrv_inc_in_flight(BlockDriverState *bs)
>> atomic_inc(&bs->in_flight);
>> }
>>
>> +void bdrv_wakeup(BlockDriverState *bs)
>> +{
>> +}
>
> Please write a doc comment explaining the semantics of this new API.
>
> Since it's a nop here it may be better to introduce bdrv_wakeup() in
> another patch.
Okay, will do.
Paolo
- [Qemu-block] [PATCH 04/18] block: add BDS field to count in-flight requests, (continued)
- [Qemu-block] [PATCH 04/18] block: add BDS field to count in-flight requests, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 06/18] qed: Implement .bdrv_drain, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 05/18] block: change drain to look only at one child at a time, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 07/18] block: introduce bdrv_poll_while and bdrv_wakeup, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 08/18] nfs: move nfs_set_events out of the while loops, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 09/18] nfs: use bdrv_poll_while and bdrv_wakeup, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 11/18] aio: introduce qemu_get_current_aio_context, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 10/18] sheepdog: use bdrv_poll_while and bdrv_wakeup, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 13/18] replication: pass BlockDriverState to reopen_backing_file, Paolo Bonzini, 2016/10/13