qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 15/22] qcow2-bitmap: add autoclear bit


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-block] [PATCH 15/22] qcow2-bitmap: add autoclear bit
Date: Mon, 24 Oct 2016 17:25:06 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

07.10.2016 23:11, Max Reitz пишет:
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
Add autoclear bit for handling rewriting image by old qemu version.
"Add support for the autoclear bit [...]"?

finally "Add support for the autoclear bit to handle rewriting image by old
qemu version" - ok?

Or I can merge this patch into two earlier patches 06 and 07.


If autoclear bit is not set, but bitmaps extension is found it
would not be loaded and warning will be generated.
"If the autoclear bit is not set, but the bitmaps extension is found,
the bitmaps will not be loaded and a warning will be generated."

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
  block/qcow2-bitmap.c |  4 ++++
  block/qcow2.c        | 12 ++++++++++--
  block/qcow2.h        |  9 +++++++++
  3 files changed, 23 insertions(+), 2 deletions(-)
Apart from the above, the patch looks good, but why does it come so late
in the series?

So with the commit message fixed:

Reviewed-by: Max Reitz <address@hidden>



--
Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]