Re: [Qemu-block] [PATCH 17/22] qmp: add autoload parameter to block-dirty-bitmap-add

[Vladimir Sementsov-Ogievskiy]

10.10.2016 19:25, Max Reitz wrote:
> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> > Optional. Default is false.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> > Signed-off-by: Denis V. Lunev <address@hidden>
> > ---
> >   blockdev.c           | 22 ++++++++++++++++++++--
> >   qapi/block-core.json |  7 ++++++-
> >   qmp-commands.hx      |  5 ++++-
> >   3 files changed, 30 insertions(+), 4 deletions(-)
> Design question: I see that being able to specify these flags when
> creating bitmaps is useful. However, would about a way for the user to
> change these flags on an existing dirty bitmap? Would you consider that
> useful?
>
> (Of course, if so, it can always be added later, we don't need it now.)

I vote for adding later, if needed. For now we don't have such scenarios.


--
Best regards,
Vladimir