[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 5/5] qapi: allow blockdev-add for ssh
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 5/5] qapi: allow blockdev-add for ssh |
Date: |
Tue, 25 Oct 2016 14:52:33 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 10/17/2016 12:32 PM, Ashijeet Acharya wrote:
> Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
> support blockdev-add for SSH network protocol driver. Use only 'struct
> InetSocketAddress' since SSH only supports connection over TCP.
>
> Signed-off-by: Ashijeet Acharya <address@hidden>
> ---
> qapi/block-core.json | 26 ++++++++++++++++++++++++--
> 1 file changed, 24 insertions(+), 2 deletions(-)
>
> +++ b/qapi/block-core.json
> @@ -1716,7 +1716,8 @@
> 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
> 'host_device', 'http', 'https', 'luks', 'null-aio', 'null-co',
> 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw',
> - 'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
> + 'replication', 'ssh', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc',
> + 'vvfat' ] }
Please update the comment just before the enum that mentions 'ssh' as an
addition in 2.8.
> +##
> +# @BlockdevOptionsSsh
> +#
> +# @server: host address
> +#
> +# @path: path to the image on the host
> +#
> +# @user: #optional user as which to connect, defaults to
> current
> +# local user name
> +#
> +# @host_key_check #optional defines how and what to check the host
> +# key against, defaults to "yes"
Please s/host_key_check/host-key-check/ - new interfaces should favor
dash, not underscore. (The C code will be the same, though.)
> +#
> +# Since 2.8
> +##
> +{ 'struct': 'BlockdevOptionsSsh',
> + 'data': { 'server': 'InetSocketAddress',
> + 'path': 'str',
> + '*user': 'str',
> + '*host_key_check': 'str' } }
Is host-key-check truly a free-form string, or is it only a finite set
of valid possibilities, where 'yes' is the default string? Would it be
better to express it as an enum instead of a raw string?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 1/5] block/ssh: Add ssh_has_filename_options_conflict(), (continued)
- [Qemu-block] [PATCH v3 1/5] block/ssh: Add ssh_has_filename_options_conflict(), Ashijeet Acharya, 2016/10/17
- [Qemu-block] [PATCH v3 2/5] util/qemu-sockets: Make inet_connect_saddr() public, Ashijeet Acharya, 2016/10/17
- [Qemu-block] [PATCH v3 3/5] block/ssh: Add InetSocketAddress and accept it, Ashijeet Acharya, 2016/10/17
- [Qemu-block] [PATCH v3 4/5] block/ssh: Use InetSocketAddress options, Ashijeet Acharya, 2016/10/17
- [Qemu-block] [PATCH v3 5/5] qapi: allow blockdev-add for ssh, Ashijeet Acharya, 2016/10/17
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/5] Allow blockdev-add for SSH, no-reply, 2016/10/17