[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 0/6] jobs: fix transactional race condition
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH v3 0/6] jobs: fix transactional race condition |
|
Date: |
Thu, 3 Nov 2016 14:21:59 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 02.11.2016 um 18:50 hat John Snow geschrieben:
> There are a few problems with transactional job completion right now.
>
> First, if jobs complete so quickly they complete before remaining jobs
> get a chance to join the transaction, the completion mode can leave well
> known state and the QLIST can get corrupted and the transactional jobs
> can complete in batches or phases instead of all together.
>
> Second, if two or more jobs defer to the main loop at roughly the same
> time, it's possible for one job's cleanup to directly invoke the other
> job's cleanup from within the same thread, leading to a situation that
> will deadlock the entire transaction.
>
> Thanks to Vladimir for pointing out these modes of failure.
Patch 1-3 and 6:
Reviewed-by: Kevin Wolf <address@hidden>
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/6] blockjob: add block_job_start, (continued)
Re: [Qemu-block] [PATCH v3 5/6] blockjob: refactor backup_start as backup_job_create, Jeff Cody, 2016/11/07
Re: [Qemu-block] [PATCH v3 0/6] jobs: fix transactional race condition,
Kevin Wolf <=