[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [RFC PATCH 4/8] quorum: Do cleanup in call
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [RFC PATCH 4/8] quorum: Do cleanup in caller coroutine |
|
Date: |
Thu, 10 Nov 2016 20:18:31 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/10/2016 11:19 AM, Kevin Wolf wrote:
> Instead of calling quorum_aio_finalize() deeply nested in what used
> to be an AIO callback, do it in the same functions that allocated the
> AIOCB.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/quorum.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
Looks clean, but again I'm weak enough on coroutines that I won't give
R-b to an RFC
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [RFC PATCH 2/8] quorum: Remove s from quorum_aio_get() arguments, (continued)
- [Qemu-block] [RFC PATCH 1/8] coroutine: Introduce qemu_coroutine_enter_if_inactive(), Kevin Wolf, 2016/11/10
- [Qemu-block] [RFC PATCH 3/8] quorum: Implement .bdrv_co_readv/writev, Kevin Wolf, 2016/11/10
- [Qemu-block] [RFC PATCH 4/8] quorum: Do cleanup in caller coroutine, Kevin Wolf, 2016/11/10
- [Qemu-block] [RFC PATCH 5/8] quorum: Inline quorum_aio_cb(), Kevin Wolf, 2016/11/10
- [Qemu-block] [RFC PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites, Kevin Wolf, 2016/11/10