Re: [Qemu-block] [RFC PATCH 2/8] quorum: Remove s from quorum_aio_get() arguments

[Paolo Bonzini]

On 10/11/2016 18:19, Kevin Wolf wrote:
> There is no point in passing the value of bs->opaque in order to
> overwrite it with itself.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/quorum.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/block/quorum.c b/block/quorum.c
> index d122299..dfa9fd3 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -171,18 +171,17 @@ static bool quorum_64bits_compare(QuorumVoteValue *a, 
> QuorumVoteValue *b)
>      return a->l == b->l;
>  }
>  
> -static QuorumAIOCB *quorum_aio_get(BDRVQuorumState *s,
> -                                   BlockDriverState *bs,
> +static QuorumAIOCB *quorum_aio_get(BlockDriverState *bs,
>                                     QEMUIOVector *qiov,
>                                     uint64_t sector_num,
>                                     int nb_sectors,
>                                     BlockCompletionFunc *cb,
>                                     void *opaque)
>  {
> +    BDRVQuorumState *s = bs->opaque;
>      QuorumAIOCB *acb = qemu_aio_get(&quorum_aiocb_info, bs, cb, opaque);
>      int i;
>  
> -    acb->common.bs->opaque = s;
>      acb->sector_num = sector_num;
>      acb->nb_sectors = nb_sectors;
>      acb->qiov = qiov;
> @@ -691,7 +690,7 @@ static BlockAIOCB *quorum_aio_readv(BlockDriverState *bs,
>                                      void *opaque)
>  {
>      BDRVQuorumState *s = bs->opaque;
> -    QuorumAIOCB *acb = quorum_aio_get(s, bs, qiov, sector_num,
> +    QuorumAIOCB *acb = quorum_aio_get(bs, qiov, sector_num,
>                                        nb_sectors, cb, opaque);
>      acb->is_read = true;
>      acb->children_read = 0;
> @@ -711,7 +710,7 @@ static BlockAIOCB *quorum_aio_writev(BlockDriverState *bs,
>                                       void *opaque)
>  {
>      BDRVQuorumState *s = bs->opaque;
> -    QuorumAIOCB *acb = quorum_aio_get(s, bs, qiov, sector_num, nb_sectors,
> +    QuorumAIOCB *acb = quorum_aio_get(bs, qiov, sector_num, nb_sectors,
>                                        cb, opaque);
>      int i;
>  
> 

Reviewed-by: Paolo Bonzini <address@hidden>