Re: [Qemu-block] [Qemu-devel] [RFC PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev()

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [RFC PATCH 0/8] quorum: Implement 
.bdrv_co_preadv/pwritev()
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
235adae quorum: Inline quorum_fifo_aio_cb()
d6f6356 quorum: Implement .bdrv_co_preadv/pwritev()
806d272 quorum: Avoid bdrv_aio_writev() for rewrites
5fc63d2 quorum: Inline quorum_aio_cb()
f741198 quorum: Do cleanup in caller coroutine
0c84966 quorum: Implement .bdrv_co_readv/writev
de49af6 quorum: Remove s from quorum_aio_get() arguments
d0e058f coroutine: Introduce qemu_coroutine_enter_if_inactive()

=== OUTPUT BEGIN ===
fatal: unrecognized argument: --no-patch
Checking PATCH 1/8: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 2/8: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 3/8: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 4/8: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 5/8: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 6/8: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 7/8: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 8/8: ...
ERROR: space required before the open parenthesis '('
#65: FILE: block/quorum.c:667:
+    } while(ret < 0 && acb->children_read < s->num_children);

total: 1 errors, 0 warnings, 55 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden