[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 9/9] quorum: Clean up quorum_aio_get()
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v2 9/9] quorum: Clean up quorum_aio_get() |
|
Date: |
Tue, 22 Nov 2016 06:54:07 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/22/2016 06:24 AM, Kevin Wolf wrote:
> Make sure that all fields of the new QuorumAIOCB are zeroed when the
> function returns even without explicitly setting them. This will protect
> us when new fields are added, removes some explicit zero assignment and
> makes the code a little nicer to read.
>
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/quorum.c | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 3/9] quorum: Implement .bdrv_co_readv/writev, (continued)
- [Qemu-block] [PATCH v2 3/9] quorum: Implement .bdrv_co_readv/writev, Kevin Wolf, 2016/11/22
- [Qemu-block] [PATCH v2 2/9] quorum: Remove s from quorum_aio_get() arguments, Kevin Wolf, 2016/11/22
- [Qemu-block] [PATCH v2 4/9] quorum: Do cleanup in caller coroutine, Kevin Wolf, 2016/11/22
- [Qemu-block] [PATCH v2 6/9] quorum: Avoid bdrv_aio_writev() for rewrites, Kevin Wolf, 2016/11/22
- [Qemu-block] [PATCH v2 7/9] quorum: Implement .bdrv_co_preadv/pwritev(), Kevin Wolf, 2016/11/22
- [Qemu-block] [PATCH v2 5/9] quorum: Inline quorum_aio_cb(), Kevin Wolf, 2016/11/22
- [Qemu-block] [PATCH v2 8/9] quorum: Inline quorum_fifo_aio_cb(), Kevin Wolf, 2016/11/22
- [Qemu-block] [PATCH v2 9/9] quorum: Clean up quorum_aio_get(), Kevin Wolf, 2016/11/22