[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: Improve commit invalid b
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img: Improve commit invalid base message |
Date: |
Wed, 30 Nov 2016 20:36:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/30/2016 08:05 PM, Max Reitz wrote:
> When trying to invoke qemu-img commit with a base image file name that
> is not part of the top image's backing chain, the user receives a rather
> plain "Base not found" error message. This is not really helpful because
> it does not explain what "not found" means, potentially leaving the user
> wondering why qemu cannot find a file despite it clearly existing in the
> file system.
>
> Improve the error message by clarifying that "not found" means "not
> found in the top image's backing chain".
>
> Reported-by: Ala Hino <address@hidden>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> Reported in: https://bugzilla.redhat.com/show_bug.cgi?id=1390991
> ---
> qemu-img.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Safe for 2.8, if the block maintainers agree.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature