[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] migration: re-active images when m
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] migration: re-active images when migration fails to complete |
|
Date: |
Tue, 6 Dec 2016 14:30:40 +0000 |
On Tue, Dec 6, 2016 at 1:42 PM, Kevin Wolf <address@hidden> wrote:
> Am 19.11.2016 um 12:43 hat zhanghailiang geschrieben:
>> Error *local_err = NULL;
>>
>> bdrv_invalidate_cache_all(&local_err);
>
> So in summary, this is a horrible patch because it checks the wrong
> thing, and for I can't really say if it covers everything it needs to
> cover, but arguably it happens to correctly fix the outcome of a
> previously failing case.
>
> Normally I would reject such a patch and require a clean solution, but
> then we're on the day of -rc3, so if you can't send v2 right away, we
> might not have the time for it.
>
> Tough call...
This bug is not a release blocker because it was already in QEMU 2.7
and not a regression.
Let's take time to understand this fully. There could be related bugs
that can be fixed if this area of QEMU is scrutinized. We can merge
fixes in -stable when consensus is reached.
Stefan