[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 3/5] blkdebug: Simplify override logic
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 3/5] blkdebug: Simplify override logic |
Date: |
Tue, 6 Dec 2016 16:15:16 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 12/06/2016 04:10 PM, Max Reitz wrote:
> On 02.12.2016 20:22, Eric Blake wrote:
>> Rather than store into a local variable, the copy to the struct
>> if the value is valid, then reporting errors otherwise,
>
> It is rather difficult to part this sentence starting from "the copy".
That's because I meant to type "then copy". (What a difference an 'n'
makes - I hope it does't imply that the batteries i my wireless keyboard
are o the declie agai, or a sig of ay other more serious problem)
>
>> it is
>> simpler to just store into the struct and report errors if the
>> value is invalid. This however requires that the struct store
>> a 64-bit number, rather than a narrower type.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>>
>> ---
>> v3: new patch
>> ---
>> block/blkdebug.c | 11 ++++-------
>> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> Anyway, thanks! If you can explain to me how to parse the commit message
> or make it easier to read:
>
> Reviewed-by: Max Reitz <address@hidden>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support, (continued)
- Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support, Max Reitz, 2016/12/06
- Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support, Eric Blake, 2016/12/06
- Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support, Max Reitz, 2016/12/06
- Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support, Eric Blake, 2016/12/06
- Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support, Max Reitz, 2016/12/06
- Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support, Eric Blake, 2016/12/06
Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support, Kevin Wolf, 2016/12/07
[Qemu-block] [PATCH v3 3/5] blkdebug: Simplify override logic, Eric Blake, 2016/12/02
[Qemu-block] [PATCH v3 4/5] blkdebug: Add ability to override unmap geometries, Eric Blake, 2016/12/02
[Qemu-block] [PATCH v3 5/5] tests: Add coverage for recent block geometry fixes, Eric Blake, 2016/12/02