Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] RFC: A VFIO based block driver for NVMe device

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/4] RFC: A VFIO based block driver for NVMe device
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ddc026b block: Add VFIO based NVMe driver
f5dd619 util: Add VFIO helper library
5608a5c util: Add a notifier list for qemu_vfree()
822462d ramblock-notifier: new

=== OUTPUT BEGIN ===
Checking PATCH 1/4: ramblock-notifier: new...
Checking PATCH 2/4: util: Add a notifier list for qemu_vfree()...
Checking PATCH 3/4: util: Add VFIO helper library...
WARNING: line over 80 characters
#184: FILE: util/vfio-helpers.c:111:
+    if (ioctl(s->device, VFIO_DEVICE_GET_REGION_INFO, 
&s->bar_region_info[index])) {

WARNING: line over 80 characters
#262: FILE: util/vfio-helpers.c:189:
+static int qemu_vfio_pci_read_config(QEMUVFIOState *s, void *buf, int size, 
int ofs)

WARNING: line over 80 characters
#264: FILE: util/vfio-helpers.c:191:
+    if (pread(s->device, buf, size, s->config_region_info.offset + ofs) == 
size) {

WARNING: line over 80 characters
#270: FILE: util/vfio-helpers.c:197:
+static int qemu_vfio_pci_write_config(QEMUVFIOState *s, void *buf, int size, 
int ofs)

ERROR: that open brace { should be on the previous line
#287: FILE: util/vfio-helpers.c:214:
+    struct vfio_group_status group_status =
+    { .argsz = sizeof(group_status) };

WARNING: line over 80 characters
#407: FILE: util/vfio-helpers.c:334:
+static void qemu_vfio_ram_block_added(RAMBlockNotifier *n, void *host, size_t 
size)

WARNING: line over 80 characters
#415: FILE: util/vfio-helpers.c:342:
+static void qemu_vfio_ram_block_removed(RAMBlockNotifier *n, void *host, 
size_t size)

total: 1 errors, 6 warnings, 746 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/4: block: Add VFIO based NVMe driver...
ERROR: Use of volatile is usually wrong: see 
Documentation/volatile-considered-harmful.txt
#145: FILE: block/nvme.c:92:
+    volatile uint32_t *doorbell;

ERROR: Use of volatile is usually wrong: see 
Documentation/volatile-considered-harmful.txt
#169: FILE: block/nvme.c:116:
+typedef volatile struct {

WARNING: line over 80 characters
#339: FILE: block/nvme.c:286:
+        DPRINTF("NVMe error cmd specific %x sq head %x sqid %x cid %x status 
%x\n",

WARNING: line over 80 characters
#626: FILE: block/nvme.c:573:
+            error_setg(errp, "Timeout while waiting for device to reset (%ld 
ms)",

WARNING: line over 80 characters
#655: FILE: block/nvme.c:602:
+            error_setg(errp, "Timeout while waiting for device to start (%ld 
ms)",

total: 2 errors, 3 warnings, 1033 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden