qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PULL 14/14] block: Rename raw-{posix, win


From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PULL 14/14] block: Rename raw-{posix, win32} to file-*.c
Date: Mon, 9 Jan 2017 08:32:17 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/09/2017 07:44 AM, Kevin Wolf wrote:
> From: Eric Blake <address@hidden>
> 
> These files deal with the file protocol, not the raw format (the
> file protocol is often used with other formats, and the raw
> format is not forced to use the file protocol).  Rename things
> to make it a bit easier to follow.
> 
> Suggested-by: Daniel P. Berrange <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: John Snow <address@hidden>
> Reviewed-by: Laszlo Ersek <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  MAINTAINERS               |    4 +-
>  block/Makefile.objs       |    4 +-
>  block/file-posix.c        | 2616 
> +++++++++++++++++++++++++++++++++++++++++++++
>  block/file-win32.c        |  781 ++++++++++++++
>  block/gluster.c           |    4 +-
>  block/raw-posix.c         | 2616 
> ---------------------------------------------
>  block/raw-win32.c         |  781 --------------

Did you forget to configure rename detection?

It doesn't impact the validity of the pull request, but sure makes for a
larger hit on the inbox.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]