[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.9] block: get rid of bdrv_io_unplugged_beg
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PATCH for-2.9] block: get rid of bdrv_io_unplugged_begin/end |
|
Date: |
Mon, 9 Jan 2017 13:21:47 +0000 |
|
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Tue, Nov 29, 2016 at 12:33:34PM +0100, Paolo Bonzini wrote:
> bdrv_io_plug and bdrv_io_unplug are only called (via their
> BlockBackend equivalents) after starting asynchronous I/O.
> bdrv_drain is not going to be called while they are running,
> because---even if a coroutine runs for some reason---it will
> only drain in the next iteration of the event loop through
> bdrv_co_yield_to_drain.
>
> So this mechanism is unnecessary, get rid of it.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block/io.c | 41 ++---------------------------------------
> include/block/block.h | 2 --
> include/block/block_int.h | 3 +--
> 3 files changed, 3 insertions(+), 43 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature