[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v1 14/15] block: rip out all traces of password
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v1 14/15] block: rip out all traces of password prompting |
Date: |
Sat, 21 Jan 2017 20:17:18 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 03.01.2017 19:28, Daniel P. Berrange wrote:
> Now that qcow & qcow2 are wired up to get encryption keys
> via the QCryptoSecret object, nothing is relying on the
> interactive prompting for passwords. All the code related
> to password prompting can thus be ripped out.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> hmp.c | 31 ---------------------
> include/monitor/monitor.h | 7 -----
> include/qemu/osdep.h | 2 --
> monitor.c | 68
> -----------------------------------------------
> qapi-schema.json | 10 +------
> qemu-img.c | 31 ---------------------
> qemu-io.c | 20 --------------
> qmp.c | 12 +--------
> util/oslib-posix.c | 66 ---------------------------------------------
> util/oslib-win32.c | 24 -----------------
> 10 files changed, 2 insertions(+), 269 deletions(-)
Nice. :-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v1 09/15] qcow: convert QCow to use QCryptoBlock for encryption, (continued)
- [Qemu-block] [PATCH v1 10/15] qcow2: make qcow2_encrypt_sectors encrypt in place, Daniel P. Berrange, 2017/01/03
- [Qemu-block] [PATCH v1 13/15] iotests: enable tests 134 and 158 to work with qcow (v1), Daniel P. Berrange, 2017/01/03
- [Qemu-block] [PATCH v1 11/15] qcow2: convert QCow2 to use QCryptoBlock for encryption, Daniel P. Berrange, 2017/01/03
- [Qemu-block] [PATCH v1 14/15] block: rip out all traces of password prompting, Daniel P. Berrange, 2017/01/03
- Re: [Qemu-block] [PATCH v1 14/15] block: rip out all traces of password prompting,
Max Reitz <=
- [Qemu-block] [PATCH v1 15/15] block: remove all encryption handling APIs, Daniel P. Berrange, 2017/01/03
- [Qemu-block] [PATCH v1 12/15] qcow2: add support for LUKS encryption format, Daniel P. Berrange, 2017/01/03
- Re: [Qemu-block] [PATCH v1 00/15] Convert QCow[2] to QCryptoBlock & add LUKS support, Max Reitz, 2017/01/25