Re: [Qemu-block] qemu-img: complains about missing iscsi option group

[Peter Lieven]

Am 24.01.2017 um 12:29 schrieb Paolo Bonzini:
> On 24/01/2017 12:25, Peter Lieven wrote:
> > Am 24.01.2017 um 12:24 schrieb Paolo Bonzini:
> > > On 19/01/2017 18:03, Daniel P. Berrange wrote:
> > > > > > Move the iscsi option registration out of vl.c and back into a
> > > > > > shared file
> > > > > > in block/ such that all programs see the options, not just the
> > > > > > emulators.
> > > > > Any preference which file? It seems no other block driver registers
> > > > > options.
> > > > ISCSI is somewhat bizarre in that it has a separate global -iscsi arg
> > > > instead of just accepting all args via the -drive spec like every other
> > > > block driver does, so there's no precedent to follow.
> > > >
> > > > So suggest we just need a block/iscsi-global.c to deal with this.
> > > Why not block/iscsi.c itself?
> > As far as I understand block/iscsi is now compiled as a shared object.
> Uh, right. :(

Okay, so a new file iscsi-static.c ?

Peter