[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/2] iov: assert that qiov->size doesn't exceed
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH 2/2] iov: assert that qiov->size doesn't exceed INT_MAX |
|
Date: |
Wed, 1 Feb 2017 22:56:29 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 01.02.2017 22:55, Alberto Garcia wrote:
> On Wed 01 Feb 2017 10:51:01 PM CET, Max Reitz <address@hidden> wrote:
>
>> The assertion probably makes sense even for them, considering that
>> size_t does not have a constant size. But I'm not entirely sold that
>> the I/O vector creation is actually the place where the assertions
>> belong.
>
> I was actually just reading virtio_blk_handle_request() and I see that
> the I/O vector is initialized before the check for the maximum request
> size that returns VIRTIO_BLK_S_IOERR.
>
> So you're probably right and it's safer not to add that assertion.
So... Apply patch 1 and hope we do everything right in the future? :-)
Max
signature.asc
Description: OpenPGP digital signature