Re: [Qemu-block] [Qemu-devel] [PATCH v12 00/24] qcow2: persistent dirty bitmaps

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v12 00/24] qcow2: persistent dirty bitmaps
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3ab5296 qmp: block-dirty-bitmap-remove: remove persistent
7381492 qcow2: add .bdrv_remove_persistent_dirty_bitmap
dc823ec block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap
0e2f45c qcow2-bitmap: refcounts
f199da8 qcow2-refcount: rename inc_refcounts() and make it public
7d85e36 iotests: test qcow2 persistent dirty bitmap
f402dde qmp: add x-debug-block-dirty-bitmap-sha256
786098c qmp: add autoload parameter to block-dirty-bitmap-add
10a6389 qmp: add persistent flag to block-dirty-bitmap-add
83697dd qcow2: add .bdrv_can_store_new_dirty_bitmap
1fc4736 block: add bdrv_can_store_new_dirty_bitmap
c5a3ac2 qcow2: add .bdrv_store_persistent_dirty_bitmaps()
46bf264 block/dirty-bitmap: add bdrv_dirty_bitmap_next()
aec8d33 block: introduce persistent dirty bitmaps
584b4fe block/dirty-bitmap: add autoload field to BdrvDirtyBitmap
8b18fb4 qcow2: add .bdrv_load_autoloading_dirty_bitmaps
43538e4 block: introduce auto-loading bitmaps
53f3bef qcow2: add bitmaps extension
7a416a5 block/dirty-bitmap: add deserialize_ones func
f14934a block: fix bdrv_dirty_bitmap_granularity signature
9b7a8d0 tests: add hbitmap iter test
b13caaf hbitmap: improve dirty iter
d673072 specs/qcow2: do not use wording 'bitmap header'
b07839c specs/qcow2: fix bitmap granularity qemu-specific note

=== OUTPUT BEGIN ===
Checking PATCH 1/24: specs/qcow2: fix bitmap granularity qemu-specific note...
Checking PATCH 2/24: specs/qcow2: do not use wording 'bitmap header'...
Checking PATCH 3/24: hbitmap: improve dirty iter...
Checking PATCH 4/24: tests: add hbitmap iter test...
Checking PATCH 5/24: block: fix bdrv_dirty_bitmap_granularity signature...
Checking PATCH 6/24: block/dirty-bitmap: add deserialize_ones func...
Checking PATCH 7/24: qcow2: add bitmaps extension...
Checking PATCH 8/24: block: introduce auto-loading bitmaps...
Checking PATCH 9/24: qcow2: add .bdrv_load_autoloading_dirty_bitmaps...
Checking PATCH 10/24: block/dirty-bitmap: add autoload field to 
BdrvDirtyBitmap...
Checking PATCH 11/24: block: introduce persistent dirty bitmaps...
Checking PATCH 12/24: block/dirty-bitmap: add bdrv_dirty_bitmap_next()...
Checking PATCH 13/24: qcow2: add .bdrv_store_persistent_dirty_bitmaps()...
WARNING: line over 80 characters
#45: FILE: block/qcow2-bitmap.c:80:
+typedef QSIMPLEQ_HEAD(Qcow2BitmapTableList, Qcow2BitmapTable) 
Qcow2BitmapTableList;

total: 0 errors, 1 warnings, 589 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 14/24: block: add bdrv_can_store_new_dirty_bitmap...
WARNING: line over 80 characters
#64: FILE: include/block/block_int.h:327:
+    bool (*bdrv_can_store_new_dirty_bitmap)(BlockDriverState *bs, const char 
*name,

total: 0 errors, 1 warnings, 40 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 15/24: qcow2: add .bdrv_can_store_new_dirty_bitmap...
Checking PATCH 16/24: qmp: add persistent flag to block-dirty-bitmap-add...
Checking PATCH 17/24: qmp: add autoload parameter to block-dirty-bitmap-add...
Checking PATCH 18/24: qmp: add x-debug-block-dirty-bitmap-sha256...
Checking PATCH 19/24: iotests: test qcow2 persistent dirty bitmap...
Checking PATCH 20/24: qcow2-refcount: rename inc_refcounts() and make it 
public...
Checking PATCH 21/24: qcow2-bitmap: refcounts...
Checking PATCH 22/24: block/dirty-bitmap: add 
bdrv_remove_persistent_dirty_bitmap...
ERROR: that open brace { should be on the previous line
#38: FILE: block/dirty-bitmap.c:350:
+    if (bs->drv && bs->drv->bdrv_remove_persistent_dirty_bitmap)
+    {

total: 1 errors, 0 warnings, 49 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 23/24: qcow2: add .bdrv_remove_persistent_dirty_bitmap...
Checking PATCH 24/24: qmp: block-dirty-bitmap-remove: remove persistent...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden