Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] hw: Deprecate unwanted use -drive if=scsi

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 0/3] hw: Deprecate unwanted use -drive if=scsi
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
81f37e5 hw/i386: Deprecate -drive if=scsi with PC machine types
e00ebe5 hw: Deprecate -drive if=scsi with non-onboard HBAs
ab0e183 hw/scsi: Concentrate -drive if=scsi auto-create in one place

=== OUTPUT BEGIN ===
Checking PATCH 1/3: hw/scsi: Concentrate -drive if=scsi auto-create in one 
place...
Checking PATCH 2/3: hw: Deprecate -drive if=scsi with non-onboard HBAs...
Checking PATCH 3/3: hw/i386: Deprecate -drive if=scsi with PC machine types...
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#70: FILE: tests/qemu-iotests/051.pc.out:122:
+qququiquit
  ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#90: FILE: tests/qemu-iotests/051.pc.out:178:
+qququiquit
  ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#100: FILE: tests/qemu-iotests/051.pc.out:188:
+qququiquit
  ^

total: 3 errors, 0 warnings, 63 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden