[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block: Remove unnecessary cases of error_propag
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH] block: Remove unnecessary cases of error_propagate() |
|
Date: |
Tue, 21 Feb 2017 17:18:54 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 21 Feb 2017 05:13:54 PM CET, Alberto Garcia wrote:
> if (rc && rc != -ENOSYS) {
> - error_propagate(errp, local_err);
> return;
> }
> - error_free(local_err);
[...]
> - if (rc && rc != -ENOSYS && rc != -EINPROGRESS) {
> - error_propagate(errp, local_err);
> - return;
> - }
> - error_free(local_err);
[...]
> rc = do_open_tray(has_device ? device : NULL,
> has_id ? id : NULL,
> - false, &err);
> + false, errp);
> if (rc && rc != -ENOSYS) {
> - error_propagate(errp, err);
> goto fail;
> }
> - error_free(err);
> - err = NULL;
I just noticed that these three changes are wrong, sorry for the noise!
Berto