qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 1/3] block: implement bdrv_snapshot_goto for blk


From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH 1/3] block: implement bdrv_snapshot_goto for blkreplay
Date: Wed, 22 Feb 2017 11:05:43 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 31.01.2017 um 12:57 hat Pavel Dovgalyuk geschrieben:
> This patch enables making snapshots with blkreplay used in
> block devices.
> 
> Signed-off-by: Pavel Dovgalyuk <address@hidden>

Specifically, I think it avoids the blkreplay_open/close sequence. Is
this what is needed to make it work?

We should probably mention in the commit message the exact reason why
implementing .bdrv_snapshot_goto, but not the other snapshot related
callbacks, fixes things. If you confirm my assumption, I can add that
while applying.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]