Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/6] block: Add VFIO based driver for NVMe device

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH v2 0/6] block: Add VFIO based driver for NVMe 
device

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2ae086a qemu-img: dma map buffers
0d6bed0 block/nvme: Implement .bdrv_dma_map and .bdrv_dma_unmap
ddc2044 block: Introduce bdrv_dma_map and bdrv_dma_unmap
fec4a5e block: Add VFIO based NVMe driver
57517a8 stubs: Add stubs for ram block notifier API
98b0e5f nvme: Move NVMe definitions to a separate header

=== OUTPUT BEGIN ===
Checking PATCH 1/6: nvme: Move NVMe definitions to a separate header...
Checking PATCH 2/6: stubs: Add stubs for ram block notifier API...
Checking PATCH 3/6: block: Add VFIO based NVMe driver...
WARNING: line over 80 characters
#187: FILE: block/nvme-vfio.c:131:
+    if (ioctl(s->device, VFIO_DEVICE_GET_REGION_INFO, 
&s->bar_region_info[index])) {

WARNING: line over 80 characters
#265: FILE: block/nvme-vfio.c:209:
+static int nvme_vfio_pci_read_config(NVMeVFIOState *s, void *buf, int size, 
int ofs)

WARNING: line over 80 characters
#267: FILE: block/nvme-vfio.c:211:
+    if (pread(s->device, buf, size, s->config_region_info.offset + ofs) == 
size) {

WARNING: line over 80 characters
#273: FILE: block/nvme-vfio.c:217:
+static int nvme_vfio_pci_write_config(NVMeVFIOState *s, void *buf, int size, 
int ofs)

WARNING: line over 80 characters
#409: FILE: block/nvme-vfio.c:353:
+static void nvme_vfio_ram_block_added(RAMBlockNotifier *n, void *host, size_t 
size)

WARNING: line over 80 characters
#416: FILE: block/nvme-vfio.c:360:
+static void nvme_vfio_ram_block_removed(RAMBlockNotifier *n, void *host, 
size_t size)

ERROR: Use of volatile is usually wrong: see 
Documentation/volatile-considered-harmful.txt
#797: FILE: block/nvme.c:34:
+    volatile uint32_t *doorbell;

ERROR: Use of volatile is usually wrong: see 
Documentation/volatile-considered-harmful.txt
#823: FILE: block/nvme.c:60:
+typedef volatile struct {

WARNING: line over 80 characters
#1302: FILE: block/nvme.c:539:
+            error_setg(errp, "Timeout while waiting for device to reset (%ld 
ms)",

WARNING: line over 80 characters
#1331: FILE: block/nvme.c:568:
+            error_setg(errp, "Timeout while waiting for device to start (%ld 
ms)",

total: 2 errors, 8 warnings, 1800 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/6: block: Introduce bdrv_dma_map and bdrv_dma_unmap...
Checking PATCH 5/6: block/nvme: Implement .bdrv_dma_map and .bdrv_dma_unmap...
Checking PATCH 6/6: qemu-img: dma map buffers...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden