Re: [Qemu-block] [Qemu-devel] [PATCH v16 08/22] qcow2: add bitmaps extension

[John Snow]

On 02/27/2017 07:27 AM, Max Reitz wrote:
> On 25.02.2017 18:07, Vladimir Sementsov-Ogievskiy wrote:
>> Add bitmap extension as specified in docs/specs/qcow2.txt.
>> For now, just mirror extension header into Qcow2 state and check
>> constraints. Also, calculate refcounts for qcow2 bitmaps, to not break
>> qemu-img check.
>>
>> For now, disable image resize if it has bitmaps. It will be fixed later.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>>  block/Makefile.objs    |   2 +-
>>  block/qcow2-bitmap.c   | 439 
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>  block/qcow2-refcount.c |   6 +
>>  block/qcow2.c          | 124 +++++++++++++-
>>  block/qcow2.h          |  27 +++
>>  5 files changed, 592 insertions(+), 6 deletions(-)
>>  create mode 100644 block/qcow2-bitmap.c
> 
> Somehow I have the feeling Kevin will find bad things in this patch, but
> since I have already approved of all of the previous patches this one is
> composed of and the changes on top of that look OK to me:
> 
> Reviewed-by: Max Reitz <address@hidden>
> 

Pretty much the same sentiment as Max.

The patchset is now organized a bit strangely, but I did R-B all the
component pieces before, and the changes look fine.


Reviewed-by: John Snow <address@hidden>