[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 11/44] block: Request real permissions in bdrv_at
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PATCH v3 11/44] block: Request real permissions in bdrv_attach_child() |
Date: |
Tue, 28 Feb 2017 13:53:56 +0100 |
Now that all block drivers with children tell us what permissions they
need from each of their children, bdrv_attach_child() can use this
information and make the right requirements while trying to attach new
children.
Signed-off-by: Kevin Wolf <address@hidden>
---
block.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 52c1f28..bed2367 100644
--- a/block.c
+++ b/block.c
@@ -1680,10 +1680,16 @@ BdrvChild *bdrv_attach_child(BlockDriverState
*parent_bs,
Error **errp)
{
BdrvChild *child;
+ uint64_t perm, shared_perm;
+
+ bdrv_get_cumulative_perm(parent_bs, &perm, &shared_perm);
+
+ assert(parent_bs->drv);
+ parent_bs->drv->bdrv_child_perm(parent_bs, NULL, child_role,
+ perm, shared_perm, &perm, &shared_perm);
- /* FIXME Use real permissions */
child = bdrv_root_attach_child(child_bs, child_name, child_role,
- 0, BLK_PERM_ALL, parent_bs, errp);
+ perm, shared_perm, parent_bs, errp);
if (child == NULL) {
return NULL;
}
--
1.8.3.1
- [Qemu-block] [PATCH v3 02/44] block: Add Error argument to bdrv_attach_child(), (continued)
- [Qemu-block] [PATCH v3 02/44] block: Add Error argument to bdrv_attach_child(), Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 04/44] block: Involve block drivers in permission granting, Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 05/44] block: Default .bdrv_child_perm() for filter drivers, Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 06/44] block: Request child permissions in filter drivers, Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 07/44] block: Default .bdrv_child_perm() for format drivers, Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 08/44] block: Request child permissions in format drivers, Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 09/44] vvfat: Implement .bdrv_child_perm(), Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 11/44] block: Request real permissions in bdrv_attach_child(),
Kevin Wolf <=
- [Qemu-block] [PATCH v3 10/44] block: Require .bdrv_child_perm() with child nodes, Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 12/44] block: Add permissions to BlockBackend, Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 13/44] block: Add permissions to blk_new(), Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 14/44] block: Add error parameter to blk_insert_bs(), Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 15/44] block: Add BDRV_O_RESIZE for blk_new_open(), Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 16/44] block: Request real permissions in blk_new_open(), Kevin Wolf, 2017/02/28
- [Qemu-block] [PATCH v3 18/44] hw/block: Request permissions, Kevin Wolf, 2017/02/28