[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PULL 5/5] block/rbd: add support for 'mon
|
From: |
Jeff Cody |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PULL 5/5] block/rbd: add support for 'mon_host', 'auth_supported' via QAPI |
|
Date: |
Tue, 28 Feb 2017 11:30:17 -0500 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Feb 28, 2017 at 10:26:49AM -0600, Eric Blake wrote:
> On 02/28/2017 10:15 AM, Jeff Cody wrote:
> > This adds support for three additional options that may be specified
> > by QAPI in blockdev-add:
> >
> > server: host, port
> > auth method: either 'cephx' or 'none'
> >
> > The "server" and "auth-supported" QAPI parameters are arrays. To conform
> > with the rados API, the array items are join as a single string with a ';'
> > character as a delimiter when setting the configuration values.
> >
> > Reviewed-by: Markus Armbruster <address@hidden>
>
> What happened to Signed-off-by? You'll have to resubmit the pull request
>
Argh, thanks - that is what happens when I go outside my normal workflow.
Will send a v2 pr
> > ---
> > block/rbd.c | 134
> > +++++++++++++++++++++++++++++++++++++++++++++++++++
> > qapi/block-core.json | 29 +++++++++++
> > 2 files changed, 163 insertions(+)
> >
>
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
- [Qemu-block] [PULL 0/5] Block patches for 2.9, Jeff Cody, 2017/02/28
- [Qemu-block] [PULL 2/5] block/rbd: add all the currently supported runtime_opts, Jeff Cody, 2017/02/28
- [Qemu-block] [PULL 1/5] block/rbd: don't copy strings in qemu_rbd_next_tok(), Jeff Cody, 2017/02/28
- [Qemu-block] [PULL 4/5] block/rbd: add blockdev-add support, Jeff Cody, 2017/02/28
- [Qemu-block] [PULL 3/5] block/rbd: parse all options via bdrv_parse_filename, Jeff Cody, 2017/02/28
- [Qemu-block] [PULL 5/5] block/rbd: add support for 'mon_host', 'auth_supported' via QAPI, Jeff Cody, 2017/02/28