qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [for-2.9 6/8] qapi-schema: SocketAddressFlat variants '


From: Eric Blake
Subject: Re: [Qemu-block] [for-2.9 6/8] qapi-schema: SocketAddressFlat variants 'vsock' and 'fd'
Date: Wed, 29 Mar 2017 15:02:51 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 03/29/2017 11:45 AM, Markus Armbruster wrote:
> Note that the new variants are impossible in qemu_gluster_glfs_init(),
> because the gconf->server can only come from qemu_gluster_parse_uri()
> or qemu_gluster_parse_json(), and neither can create anything but
> 'tcp' or 'unix'.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  block/gluster.c  |  2 ++
>  qapi-schema.json | 19 ++++++++-----------
>  2 files changed, 10 insertions(+), 11 deletions(-)

> +# This is just like SocketAddress, except it's a flat union rather
> +# than a simple union.  Nicer because it avoids nesting (i.e. more {})
> +# on the wire.
>  #
>  # Since: 2.9
>  ##
>  { 'union': 'SocketAddressFlat',
>    'base': { 'type': 'SocketAddressFlatType' },
>    'discriminator': 'type',
> -  'data': { 'unix': 'UnixSocketAddress',
> -            'inet': 'InetSocketAddress' } }
> +  'data': { 'inet': 'InetSocketAddress',
> +            'unix': 'UnixSocketAddress',
> +            'vsock': 'VsockSocketAddress',
> +            'fd': 'String' } }

Can we make 'fd':'str'?  That would be even less pointless nesting on
the wire.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]