[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [RFC v2 for-2.9 06/10] qapi-schema: Socket
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-block] [Qemu-devel] [RFC v2 for-2.9 06/10] qapi-schema: SocketAddressFlat variants 'vsock' and 'fd' |
Date: |
Thu, 30 Mar 2017 16:59:43 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 03/30/2017 08:15 AM, Markus Armbruster wrote:
>> Note that the new variants are impossible in qemu_gluster_glfs_init(),
>> because the gconf->server can only come from qemu_gluster_parse_uri()
>> or qemu_gluster_parse_json(), and neither can create anything but
>> 'inet' or 'unix'.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Max Reitz <address@hidden>
>> ---
>> block/gluster.c | 2 ++
>> qapi-schema.json | 19 ++++++++-----------
>> 2 files changed, 10 insertions(+), 11 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
>
>> -# 2. SocketAddressFlat supports only types 'unix' and 'inet', because
>> -# that's what its current users need.
>> +# This is just like SocketAddress, except it's a flat union rather
>> +# than a simple union. Nicer because it avoids nesting (i.e. more {})
>> +# on the wire.
>
> I know that you are explaining that it is "nesting" which means "more
> {}", but it is SocketAddress that has the extra {}, not
> SocketAddressFlat. I wonder if it reads any better as:
>
> Nicer because it avoids nesting on the wire (i.e. this form has fewer {}).
Sold! (Except I'm peeling off the parenthesis)
- Re: [Qemu-block] [RFC v2 for-2.9 04/10] block: Document -drive problematic code and bugs, (continued)
- [Qemu-block] [RFC v2 for-2.9 05/10] gluster: Prepare for SocketAddressFlat extension, Markus Armbruster, 2017/03/30
- [Qemu-block] [RFC v2 for-2.9 08/10] nbd: Tidy up blockdev-add interface, Markus Armbruster, 2017/03/30
- [Qemu-block] [RFC v2 for-2.9 03/10] io vnc sockets: Clean up SocketAddressKind switches, Markus Armbruster, 2017/03/30
- [Qemu-block] [RFC v2 for-2.9 06/10] qapi-schema: SocketAddressFlat variants 'vsock' and 'fd', Markus Armbruster, 2017/03/30
- [Qemu-block] [RFC v2 for-2.9 02/10] char: Fix socket with "type": "vsock" address, Markus Armbruster, 2017/03/30
- [Qemu-block] [RFC v2 for-2.9 07/10] sockets: New helper socket_address_crumple(), Markus Armbruster, 2017/03/30
- [Qemu-block] [RFC v2 for-2.9 01/10] nbd sockets vnc: Mark problematic address family tests TODO, Markus Armbruster, 2017/03/30
- Re: [Qemu-block] [RFC v2 for-2.9 00/10] Fixes and cleanups around SocketAddress, Kashyap Chamarthy, 2017/03/30