Re: [Qemu-block] [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

[Paolo Bonzini]

On 05/04/2017 11:01, Richard W.M. Jones wrote:
> On Wed, Apr 05, 2017 at 10:38:37AM +0200, Julia Lawall wrote:
>> OK, there is nothing special about g_assert_cmpint, but Coccinelle expects
>> expressions or types in function argument lists, so it gives a parse error
>> on finding an ==.
> 
> I should have checked the coccinelle mailing list before asking you,
> because I see that Eric already asked this question and you answered
> it.  For reference, that is here:
> 
>   https://systeme.lip6.fr/pipermail/cocci/2017-April/004107.html
> 
> Thanks again,

Eric, are you using the scripts/cocci-macro-file.h?

    commit 6ad978e9f40d3edfd9f4a86b4a60e3523eff08fe
    Author: Paolo Bonzini <address@hidden>
    Date:   Wed May 18 11:11:55 2016 +0200

    coccinelle: add g_assert_cmp* to macro file

    This helps applying semantic patches to unit tests.

    Signed-off-by: Paolo Bonzini <address@hidden>

Thanks,

Paolo