[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.9] throttle: Remove block from group on ho
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH for-2.9] throttle: Remove block from group on hot-unplug |
|
Date: |
Fri, 7 Apr 2017 16:19:09 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 06.04.2017 21:08, Eric Blake wrote:
> When a block device that is part of a throttle group is hot-unplugged,
> we forgot to remove it from the throttle group. This leaves stale
> memory around, and causes an easily reproducible crash:
>
> $ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic -qmp stdio \
> -device virtio-scsi-pci,bus=pci.0 -drive \
> id=drive_image2,if=none,format=raw,file=file2,bps=512000,iops=100,group=foo \
> -device scsi-hd,id=image2,drive=drive_image2 -drive \
> id=drive_image3,if=none,format=raw,file=file3,bps=512000,iops=100,group=foo \
> -device scsi-hd,id=image3,drive=drive_image3
> {'execute':'qmp_capabilities'}
> {'execute':'device_del','arguments':{'id':'image3'}}
> {'execute':'system_reset'}
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1428810
>
> Suggested-by: Alberto Garcia <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
> ---
> block/block-backend.c | 3 +++
> 1 file changed, 3 insertions(+)
Thanks, applied to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
signature.asc
Description: OpenPGP digital signature