Re: [Qemu-block] [Qemu-devel] [PATCH v3] migration/block: use blk_pwrite_zeroes for each zero cluster

[Fam Zheng]

On Mon, 04/10 09:10, 858585 jemmy wrote:
> >> +                        if (ret < 0) {
> >> +                            g_free(buf);
> >> +                            return ret;
> >> +                        }
> >
> > This if block is not necessary because...
> 
> Hi Fam:
>       It's necessary to check each cluster is written successfully.
>       if we remove this if block, it maybe ignore some error, and only check
>       the last cluster.
>       Thanks.

Yes, I missed the fact it is in the loop body. My bad. Thanks for pointint out:

Reviewed-by: Fam Zheng <address@hidden>