Re: [Qemu-block] [Qemu-devel] [PATCH RFC 2/3] qemu-img: Add --unsafe-read option to subcommands

[Fam Zheng]

On Tue, 04/18 08:20, Eric Blake wrote:
> bool, please.  (Just because existing code is lousy with using an int
> for a bool doesn't mean we should perpetuate it)

OK, will fix.

> 
> 
> > @@ -3033,6 +3085,9 @@ static int img_rebase(int argc, char **argv)
> >          case OPTION_IMAGE_OPTS:
> >              image_opts = true;
> >              break;
> > +        case 'U':
> > +            unsafe_read = 1;
> 
> s/1/true/
> 
> Good patch, but missing documentation updates to --help/man page.  So,
> as encouragement to add that when you drop the RFC, I'll withhold my R-b
> until then. ;)

Yes, I'll add another patch for ease of review.

Fam