[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 2/3] qemu-img/convert: Move bs_n > 1 && -B ch
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 2/3] qemu-img/convert: Move bs_n > 1 && -B check down |
Date: |
Wed, 26 Apr 2017 09:19:14 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 04/26/2017 08:46 AM, Max Reitz wrote:
> It does not make much sense to use a backing image for the target when
> you concatenate multiple images (because then there is no correspondence
> between the source images' backing files and the target's); but it was
> still possible to give one by using -o backing_file=X instead of -B X.
>
> Fix this by moving the check.
>
> (Also, change the error message because -B is not the only way to
> specify the backing file, evidently.)
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> qemu-img.c | 13 +++++++------
> tests/qemu-iotests/122.out | 4 ++--
> 2 files changed, 9 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature