[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v1 3/8] dmg: Limit the output buffe
From: |
Ashijeet Acharya |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v1 3/8] dmg: Limit the output buffer size to a max of 2MB |
Date: |
Thu, 27 Apr 2017 12:59:45 +0530 |
On Thu, Apr 27, 2017 at 12:56 PM, Fam Zheng <address@hidden> wrote:
> On Wed, 04/26 17:30, John Snow wrote:
>> Seems OK otherwise, but I would normally expect you to fix the buffering
>> problems first, and then reduce the size of the buffer -- not the other
>> way around. This version introduces new limitations that didn't exist
>> previously (As of this commit, QEMU can't open DMG files with chunks
>> larger than 2MB now, right?)
>
> Yes, each commit should _not_ introduce issues (compiling failures, functional
> degeneration, etc.), and cannot rely on following commits to fix things
> screwed
> up in this one.
>
> This is important for bisectability - each commit can be built and tested in
> the
> whole git history.
Yes, understood. That's why I am gonna squash it with the last patch
(patch 8) which removes this limitation completely.
Ashijeet
- [Qemu-block] [PATCH v1 0/8] Refactor DMG driver to have chunk size independence, Ashijeet Acharya, 2017/04/25
- [Qemu-block] [PATCH v1 4/8] dmg: Refactor and prepare dmg_read_chunk() to cache random access points, Ashijeet Acharya, 2017/04/25
- [Qemu-block] [PATCH v1 5/8] dmg: Handle zlib compressed chunks, Ashijeet Acharya, 2017/04/25
- [Qemu-block] [PATCH v1 6/8] dmg: Handle bz2 compressed/raw/zeroed chunks, Ashijeet Acharya, 2017/04/25
- [Qemu-block] [PATCH v1 7/8] dmg: Refactor dmg_co_preadv() to start reading multiple sectors, Ashijeet Acharya, 2017/04/25
- [Qemu-block] [PATCH v1 8/8] dmg: Remove the error messages to allow wild images, Ashijeet Acharya, 2017/04/25