[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v16 15/22] file-posix: Add 'locking' option
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v16 15/22] file-posix: Add 'locking' option |
Date: |
Tue, 2 May 2017 16:15:20 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 02.05.2017 um 10:18 hat Fam Zheng geschrieben:
> Making this option available even before implementing it will let
> converting tests easier: in coming patches they can specify the option
> already when necessary, before we actually write code to lock the
> images.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/file-posix.c | 5 +++++
> qapi/block-core.json | 4 ++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/block/file-posix.c b/block/file-posix.c
> index ade71db..0fb3b31 100644
> --- a/block/file-posix.c
> +++ b/block/file-posix.c
> @@ -392,6 +392,11 @@ static QemuOptsList raw_runtime_opts = {
> .type = QEMU_OPT_STRING,
> .help = "host AIO implementation (threads, native)",
> },
> + {
> + .name = "locking",
> + .type = QEMU_OPT_STRING,
> + .help = "file locking mode (on/off/auto, default:auto)",
There should be a space after the colon.
On the other hand, this message isn't displayed anywhere anyway...
> + },
> { /* end of list */ }
> },
> };
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 1cf29a1..29d3040 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2127,11 +2127,15 @@
> #
> # @filename: path to the image file
> # @aio: AIO backend (default: threads) (since: 2.8)
> +# @locking: whether to enable file locking. If set to 'auto', only enable
> +# when Open File Descriptor (OFD) locking API is available
> +# (default: auto, since 2.10)
> #
> # Since: 2.9
> ##
> { 'struct': 'BlockdevOptionsFile',
> 'data': { 'filename': 'str',
> + '*locking': 'OnOffAuto',
> '*aio': 'BlockdevAioOptions' } }
It's unfortunate that file-posix and file-win32 share the same QAPI
type. Should we add a file-win32 implementation that just errors out
when locking=on is specified, or is it enough that block.c notices that
there is an option that hasn't been processed? (Even locking=off would
cause failure then.)
Kevin
- Re: [Qemu-block] [PATCH v16 05/22] qemu-img: Update documentation for -U, (continued)
- [Qemu-block] [PATCH v16 06/22] qemu-io: Add --force-share option, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 07/22] iotests: 030: Prepare for image locking, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 08/22] iotests: 046: Prepare for image locking, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 09/22] iotests: 055: Don't attach the target image already for drive-backup, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 10/22] iotests: 085: Avoid image locking conflict, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 11/22] iotests: 087: Don't attach test image twice, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 12/22] iotests: 091: Quit QEMU before checking image, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 13/22] iotests: 172: Use separate images for multiple devices, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 15/22] file-posix: Add 'locking' option, Fam Zheng, 2017/05/02
- Re: [Qemu-block] [PATCH v16 15/22] file-posix: Add 'locking' option,
Kevin Wolf <=
- [Qemu-block] [PATCH v16 14/22] tests: Use null-co:// instead of /dev/null as the dummy image, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 16/22] tests: Disable image lock in test-replication, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 17/22] block: Reuse bs as backing hd for drive-backup sync=none, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 18/22] osdep: Add qemu_lock_fd and qemu_unlock_fd, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 19/22] osdep: Fall back to posix lock when OFD lock is unavailable, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 20/22] file-posix: Add image locking to perm operations, Fam Zheng, 2017/05/02
- [Qemu-block] [PATCH v16 22/22] tests: Add POSIX image locking test case 182, Fam Zheng, 2017/05/02