Re: [Qemu-block] migration: add incremental drive-mirror and blockdev-mirror with dirtymap

[Eric Blake]

[qemu-devel added in cc]

On 05/02/2017 09:26 AM, Daniel Kučera wrote:
> added parameter bitmap which will be used instead of newly created dirtymap
> in mirror_start_job
> 
> diff --git i/block/mirror.c w/block/mirror.c

All patches MUST be sent to address@hidden, in addition to
whatever other lists (including qemu-block, which you chose) are
specified by scripts/get_maintainer.pl.

Furthermore, ALL patches must have Signed-off-by: attribution that you
are legally able to submit the patch and agree to its proper licensing.
Without that, we can't take it.

Your patch is also missing diffstat information, which 'git
format-patch' includes by default, and which can quickly let readers
gauge the scope of your patch by the size of the changes to the files it
touches.

For more patch submission hints, see:
http://wiki.qemu.org/Contribute/SubmitAPatch


> +++ w/qapi/block-core.json
> @@ -1502,6 +1502,10 @@
>  #
>  # @speed:  the maximum speed, in bytes per second
>  #
> +# @bitmap: the name of dirty bitmap if sync is "incremental".
> +#          Must be present if sync is "incremental", must NOT be present
> +#          otherwise. (Since 2.4)

Whoa - you've missed 2.4 by 5 releases.  Now that 2.9 is released, new
additions should be marked since 2.10.

> +#
>  # @sync: what parts of the disk image should be copied to the destination
>  #        (all the disk, only the sectors allocated in the topmost image, or
>  #        only new I/O).
> @@ -1533,7 +1537,7 @@
>    'data': { '*job-id': 'str', 'device': 'str', 'target': 'str',
>              '*format': 'str', '*node-name': 'str', '*replaces': 'str',
>              'sync': 'MirrorSyncMode', '*mode': 'NewImageMode',
> -            '*speed': 'int', '*granularity': 'uint32',
> +            '*speed': 'int', '*bitmap': 'str', '*granularity': 'uint32',
>              '*buf-size': 'int', '*on-source-error': 'BlockdevOnError',
>              '*on-target-error': 'BlockdevOnError',
>              '*unmap': 'bool' } }
> @@ -1652,6 +1656,10 @@
>  #
>  # @speed:  the maximum speed, in bytes per second
>  #
> +# @bitmap: the name of dirty bitmap if sync is "incremental".
> +#          Must be present if sync is "incremental", must NOT be present
> +#          otherwise. (Since 2.4)

and again

> +#
>  # @sync: what parts of the disk image should be copied to the destination
>  #        (all the disk, only the sectors allocated in the topmost image, or
>  #        only new I/O).
> @@ -1694,7 +1702,7 @@
>    'data': { '*job-id': 'str', 'device': 'str', 'target': 'str',
>              '*replaces': 'str',
>              'sync': 'MirrorSyncMode',
> -            '*speed': 'int', '*granularity': 'uint32',
> +            '*speed': 'int', '*bitmap': 'str', '*granularity': 'uint32',
>              '*buf-size': 'int', '*on-source-error': 'BlockdevOnError',
>              '*on-target-error': 'BlockdevOnError',
>              '*filter-node-name': 'str' } }
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature