[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 09/11] blockjob: strengthen a bit test-blockjob-txn
From: |
Paolo Bonzini |
Subject: |
[Qemu-block] [PATCH 09/11] blockjob: strengthen a bit test-blockjob-txn |
Date: |
Mon, 8 May 2017 16:13:08 +0200 |
Unlike test-blockjob-txn, QMP releases the reference to the transaction
before the jobs finish. Thus, qemu-iotest 124 showed a failure while
working on the next patch that the unit tests did not have. Make
the test a little nastier.
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: John Snow <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
tests/test-blockjob-txn.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/test-blockjob-txn.c b/tests/test-blockjob-txn.c
index 0f80194e85..c77343fc04 100644
--- a/tests/test-blockjob-txn.c
+++ b/tests/test-blockjob-txn.c
@@ -167,6 +167,11 @@ static void test_pair_jobs(int expected1, int expected2)
block_job_start(job1);
block_job_start(job2);
+ /* Release our reference now to trigger as many nice
+ * use-after-free bugs as possible.
+ */
+ block_job_txn_unref(txn);
+
if (expected1 == -ECANCELED) {
block_job_cancel(job1);
}
@@ -187,8 +192,6 @@ static void test_pair_jobs(int expected1, int expected2)
g_assert_cmpint(result1, ==, expected1);
g_assert_cmpint(result2, ==, expected2);
-
- block_job_txn_unref(txn);
}
static void test_pair_jobs_success(void)
--
2.12.2
- Re: [Qemu-block] [PATCH 04/11] blockjob: introduce block_job_pause/resume_all, (continued)
- [Qemu-block] [PATCH 05/11] blockjob: separate monitor and blockjob APIs, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 06/11] blockjob: move iostatus reset inside block_job_user_resume, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 07/11] blockjob: introduce block_job_cancel_async, check iostatus invariants, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 08/11] blockjob: group BlockJob transaction functions together, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 10/11] blockjob: reorganize block_job_completed_txn_abort, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 11/11] blockjob: use deferred_to_main_loop to indicate the coroutine has ended, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 09/11] blockjob: strengthen a bit test-blockjob-txn,
Paolo Bonzini <=
- Re: [Qemu-block] [PATCH v2 00/11] Preparation for block job mutex, Paolo Bonzini, 2017/05/21
- Re: [Qemu-block] [PATCH v2 00/11] Preparation for block job mutex, Jeff Cody, 2017/05/22