[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 14/17] block: optimize access to reqs_lock
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH 14/17] block: optimize access to reqs_lock |
|
Date: |
Mon, 8 May 2017 18:30:58 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 08/05/2017 18:21, Stefan Hajnoczi wrote:
> If you want to use spinlocks in QEMU please document strict rules that
> ensure they will be used safely. For example, I'd be comfortable with:
>
> Spinlock regions may only call functions in the same source file or
> functions explicitly documented as spinlock-safe. Only memory accesses
> and computation may be performed; do not make system calls or invoke
> library functions.
Sounds good. But for now I'll just drop these patches in the interest
of simplicity.
Paolo