[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2] qemu-img: Check for backing image if specifi
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH v2] qemu-img: Check for backing image if specified during create |
|
Date: |
Thu, 11 May 2017 11:37:39 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 09.05.2017 um 20:09 hat John Snow geschrieben:
> Or, rather, force the open of a backing image if one was specified
> for creation. Using a similar -unsafe option as rebase, allow qemu-img
> to ignore the backing file validation if possible.
>
> It may not always be possible, as in the existing case when a filesize
> for the new image was not specified.
>
> This is accomplished by shifting around the conditionals in
> bdrv_img_create, such that a backing file is always opened unless we
> provide BDRV_O_NO_BACKING. qemu-img is adjusted to pass this new flag
> when -u is provided to create.
>
> Sorry for the heinous looking diffstat, but it's mostly whitespace.
>
> Inspired by: https://bugzilla.redhat.com/show_bug.cgi?id=1213786
>
> Signed-off-by: John Snow <address@hidden>
The idea makes sense to me, but the patch needs a rebase.
Kevin