Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/18] Block layer thread safety, part 1

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/18] Block layer thread safety, part 1
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7a1754a block: make accounting thread-safe
f0c9191 block: introduce block_account_one_io
4f3bb4c block: protect modification of dirty bitmaps with a mutex
5a4fc48 migration/block: reset dirty bitmap before reading
775f600 block: introduce dirty_bitmap_mutex
422e33d block: protect tracked_requests and flush_queue with reqs_lock
4e2baa2 block: access write_gen with atomics
bbc9d96 block: use Stat64 for wr_highest_offset
605fbfe util: add stats64 module
6eac82d throttle-groups: protect throttled requests with a CoMutex
78fee67 throttle-groups: do not use qemu_co_enter_next
60df99f throttle-groups: only start one coroutine from drained_begin
e840cf3 block: access io_plugged with atomic ops
5c8b6d7 block: access wakeup with atomic ops
a217a89 block: access serialising_in_flight with atomic ops
0e087dd block: access io_limits_disabled with atomic ops
d03e63c block: access quiesce_counter with atomic ops
e9bd2e7 block: access copy_on_read with atomic ops

=== OUTPUT BEGIN ===
Checking PATCH 1/18: block: access copy_on_read with atomic ops...
Checking PATCH 2/18: block: access quiesce_counter with atomic ops...
Checking PATCH 3/18: block: access io_limits_disabled with atomic ops...
Checking PATCH 4/18: block: access serialising_in_flight with atomic ops...
Checking PATCH 5/18: block: access wakeup with atomic ops...
Checking PATCH 6/18: block: access io_plugged with atomic ops...
Checking PATCH 7/18: throttle-groups: only start one coroutine from 
drained_begin...
Checking PATCH 8/18: throttle-groups: do not use qemu_co_enter_next...
Checking PATCH 9/18: throttle-groups: protect throttled requests with a 
CoMutex...
Checking PATCH 10/18: util: add stats64 module...
ERROR: memory barrier without comment
#327: FILE: util/stats64.c:101:
+        smp_wmb();

ERROR: memory barrier without comment
#356: FILE: util/stats64.c:130:
+        smp_wmb();

total: 2 errors, 0 warnings, 334 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 11/18: block: use Stat64 for wr_highest_offset...
Checking PATCH 12/18: block: access write_gen with atomics...
Checking PATCH 13/18: block: protect tracked_requests and flush_queue with 
reqs_lock...
Checking PATCH 14/18: block: introduce dirty_bitmap_mutex...
Checking PATCH 15/18: migration/block: reset dirty bitmap before reading...
Checking PATCH 16/18: block: protect modification of dirty bitmaps with a 
mutex...
WARNING: line over 80 characters
#303: FILE: migration/block.c:540:
+            bdrv_reset_dirty_bitmap_locked(bmds->dirty_bitmap, sector, 
nr_sectors);

total: 0 errors, 1 warnings, 272 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 17/18: block: introduce block_account_one_io...
ERROR: line over 90 characters
#20: FILE: block/accounting.c:89:
+static void block_account_one_io(BlockAcctStats *stats, BlockAcctCookie 
*cookie, bool failed)

total: 1 errors, 0 warnings, 74 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 18/18: block: make accounting thread-safe...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden